fix

MyOffice.Web/Controllers/SettingsItemController.cs

@@ -1,14 +1,13 @@
 namespace MyOffice.Web.Controllers;
 
-using Data.Models.Items;
-using Data.Repositories.Account;
+using AutoMapper;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
+
 using Models.Item;
-using MyOffice.Core.Extensions;
-using MyOffice.Core;
-using MyOffice.Services.Account;
-using MyOffice.Services.Account.Domain;
+using Core.Extensions;
+using Core;
+using Infrastructure.Attributes;
 using Services.Item;
 using Services.Item.Domain;
 
@@ -18,42 +17,43 @@ using Services.Item.Domain;
 public class SettingsItemController : BaseApiController
 {
 	private ILogger<SettingsItemController> _logger;
-
+	private IMapper _mapper;
 	private ItemService _itemService;
 
 	public SettingsItemController(
 		ILogger<SettingsItemController> logger,
-		ItemService itemService
+		ItemService itemService,
+		IMapper mapper
 	)
 	{
 		_itemService = itemService;
 		_logger = logger;
+		_mapper = mapper;
 	}
 
 	[HttpGet("~/api/settings/item-categories")]
-	public object ItemsCategories()
+	public ObjectResult ItemsCategories()
 	{
 		var list = _itemService.GetAllCategories(UserId);
 
-		return list
-			.Select(x => x.ToModel())
+		return Ok(_mapper.Map<List<ItemCategoryViewModel>>(list)
 			.OrderByDescending(x => x.SortOrder)
-			.ThenBy(x => x.Name);
+			.ThenBy(x => x.Name));
 	}
 
 	[HttpPost("~/api/settings/item-categories")]
-	public object ItemCategoriesAdd(ItemCategoryViewModel request)
+	public ObjectResult ItemCategoriesAdd(ItemCategoryViewModel request)
 	{
 		var exec = _itemService.CategoryAdd(UserId, request.FromModel());
 
 		switch (exec.Status)
 		{
 			case GeneralExecStatus.success:
-				return exec.Result!.ToModel();
+				return Ok(_mapper.Map<ItemCategoryViewModel>(exec.Result!));
 
 			case GeneralExecStatus.failure:
 			case GeneralExecStatus.not_found:
-				return ProblemBadRequest("Adding item category failed.");
+				return ProblemBadResponse("Adding item category failed.");
 
 			default:
 				throw new NotSupportedException(exec.Status.ToString());
@@ -61,18 +61,18 @@ public class SettingsItemController : BaseApiController
 	}
 
 	[HttpPut("~/api/settings/item-categories/{id}")]
-	public object ItemCategoriesEdit(string id, ItemCategoryViewModel request)
+	public ObjectResult ItemCategoriesUpdate([AsGuid] string id, ItemCategoryViewModel request)
 	{
 		var exec = _itemService.CategoryUpdate(UserId, id.AsGuid(), request.FromModel());
 
 		switch (exec.Status)
 		{
 			case GeneralExecStatus.success:
-				return exec.Result!.ToModel();
+				return Ok(_mapper.Map<ItemCategoryViewModel>(exec.Result!));
 
 			case GeneralExecStatus.failure:
 			case GeneralExecStatus.not_found:
-				return ProblemBadRequest("Update item category failed.");
+				return ProblemBadResponse("Update item category failed.");
 
 			default:
 				throw new NotSupportedException(exec.Status.ToString());
@@ -80,20 +80,20 @@ public class SettingsItemController : BaseApiController
 	}
 
 	[HttpDelete("~/api/settings/item-categories/{id}")]
-	public object ItemCategoriesDelete(string id)
+	public ObjectResult ItemCategoriesDelete([AsGuid] string id)
 	{
 		var exec = _itemService.CategoryRemove(UserId, id.AsGuid());
 		switch (exec.Status)
 		{
 			case ItemCategoryRemoveResult.success:
-				return exec.Result!;
+				return Ok(_mapper.Map<ItemCategoryViewModel>(exec.Result!));
 
 			case ItemCategoryRemoveResult.failure:
-				return ProblemBadRequest("Remove item category failed.");
+				return ProblemBadResponse("Remove item category failed.");
 			case ItemCategoryRemoveResult.not_found:
-				return ProblemBadRequest("Account item not found.");
+				return ProblemBadResponse("Account item not found.");
 			case ItemCategoryRemoveResult.accounts_exists:
-				return ProblemBadRequest("Account motion have accounts.");
+				return ProblemBadResponse("Account motion have accounts.");
 
 			default:
 				throw new NotSupportedException(exec.Status.ToString());
@@ -101,29 +101,28 @@ public class SettingsItemController : BaseApiController
 	}
 
 	[HttpGet("~/api/settings/items")]
-	public object Items(string? category)
+	public ObjectResult Items([AsGuid] string? category)
 	{
 		var list = category.IsMissing()
 			? _itemService.GetAll(UserId)
 			: _itemService.GetByCategory(UserId, category!.AsGuid());
 
-		return list
-			.OrderBy(x => x.ItemGlobal.Name)
-			.Select(x => x.ToModel());
+		return Ok(_mapper.Map<List<ItemViewModel>>(list.OrderBy(x => x.Name)));
 	}
 
 	[HttpPut("~/api/settings/items/{id}")]
-	public object Items(string id, ItemEditModel request)
+	public ObjectResult Items([AsGuid] string id, ItemEditModel request)
 	{
 		var exec = _itemService.Update(UserId, id.AsGuid(), request.Category.AsGuid());
+
 		switch (exec.Status)
 		{
 			case GeneralExecStatus.not_found:
-				return ProblemBadRequest("Item not found.");
+				return ProblemBadResponse("Item not found.");
 			case GeneralExecStatus.failure:
-				return ProblemBadRequest("Item update failed.");
+				return ProblemBadResponse("Item update failed.");
 			case GeneralExecStatus.success:
-				return Ok(exec.Result!.ToModel());
+				return Ok(_mapper.Map<ItemViewModel>(exec.Result!));
 
 			default:
 				throw new NotSupportedException(exec.Status.ToString());